News Feed
Sections




News Archive
Looking for more information on how to do PHP the right way? Check out PHP: The Right Way

Brandon Savage's Blog:
Superglobals In Classes Revisited
July 14, 2009 @ 07:51:11

Revisiting an earlier post dealing with superglobals and classes, Brandon Savage looks at an example of why its still a bad idea.

I asserted at the time that superglobals inside of a class violated some basic rules on what a class was supposed to do. Today, I am revisiting that discussion. The placement of superglobals inside a class creates an impossible situation for code reuse. [...] Ehat happens when we want to move this [code] to another site? Unless we leave our form fields named [the same] we'll have to modify the original code.

His alternative - a much better refactoring - lets the verifyCredentials method take in the username and password and has the calling script define where those come from, either from a local or global location.

0 comments voice your opinion now!
refactor revisit class superglobal


blog comments powered by Disqus

Similar Posts

DevShed: Building a More Capable Validation Helper Class

Gonzalo Ayuso's Blog: Using PHP classes to store configuration data

Brandon Savage: When To Write Bad Code

Gareth Heyes' Blog: Exploiting PHP SELF

LotsOfCode.com: Tag Cloud Tutorial


Community Events





Don't see your event here?
Let us know!


introduction list install framework tips voicesoftheelephpant podcast bugfix api laravel interview community symfony release language deployment package series library opinion

All content copyright, 2014 PHPDeveloper.org :: info@phpdeveloper.org - Powered by the Solar PHP Framework